Fix "omitempty" typo #884
Merged
Fix "omitempty" typo #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tibor Vass <[email protected]>
Member
|
LGTM for after the freeze |
Member
|
LGTM |
Member
|
LGTM |
Member
|
@vbatts oh, i didn't know if we were still merging stuff or waiting until the release is done |
Member
|
we can merge. It won't affect the tagged commit.
…On Thu, Jul 6, 2017 at 10:02 PM Michael Crosby ***@***.***> wrote:
@vbatts <https://github.com/vbatts> oh, i didn't know if we were still
merging stuff or waiting until the release is done
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#884 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEF6bN_yDzxqijL3qFUnfTpgIQHZzNoks5sLZGogaJpZM4OP6yB>
.
|
Member
|
not unless you want to _include_ this in the tagged commit. Then I would
need to update the PR for the version bump.
…On Thu, Jul 6, 2017 at 10:33 PM Vincent Batts ***@***.***> wrote:
we can merge. It won't affect the tagged commit.
On Thu, Jul 6, 2017 at 10:02 PM Michael Crosby ***@***.***>
wrote:
> @vbatts <https://github.com/vbatts> oh, i didn't know if we were still
> merging stuff or waiting until the release is done
>
> —
> You are receiving this because you were mentioned.
>
>
> Reply to this email directly, view it on GitHub
> <#884 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAEF6bN_yDzxqijL3qFUnfTpgIQHZzNoks5sLZGogaJpZM4OP6yB>
> .
>
|
This was referenced Jul 11, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tibor Vass [email protected]